Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix workspace urls to allow direct navigations to the workspace relative pages #120

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jessieweiyi
Copy link
Contributor

@jessieweiyi jessieweiyi commented Jun 18, 2024

Issue #, if available:

Description of changes:

The original PR #119 was causing the GitHub page issue due to usage of useNavigation outside of react router. And the commit has been reverted.

This PR includes the original PR and also fix the Github page issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi requested a review from dboyd13 June 18, 2024 05:14
Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dboyd13 dboyd13 merged commit b38165d into main Jun 18, 2024
2 checks passed
@dboyd13 dboyd13 deleted the fix/workspace-url-take2 branch June 18, 2024 22:25
Copy link

🎉 This PR is included in version 1.0.50 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants