tough: support the loading of an expired repo in unsafe mode #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
force-pushed
the
pr/expired
branch
2 times, most recently
from
1785e90
to
8d192c4
Compare
zmrow
reviewed
May 15, 2020
There was a problem hiding this comment.
Looks good!
Two things:
- This is a API-breaking change so we'll want to make sure that we bump the minor version of the entire library and update the changelog.
- We'll probably want to add an argument to
tuftoolso a user can download an expired repo. This is also an API breaking change and deserves a version bump.
Let's get @iliana 's eyes on this too. :)
Agreed. The versions are already bumped to 0.5.0 and I plan to write the changelog in a separate release PR.
Yes, that could be added separately if we want the functionality exposed. |
iliana
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #112
Supports bottlerocket-os/bottlerocket#905
Supports bottlerocket-os/bottlerocket#91
Description of changes:
Add a setting to the
Settingsobject such that we can choose to load a repository with expired metadata if we want to. This supports a use case in Bottlerocket when we need to load a cached, local repository without access to networking, and where failing due to an expiration cannot be tolerated.I used an enum for this setting,
UnsafevsSafeto make it clearer what this setting does, and thus harder to accidentally choose incorrectly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.