Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StsProperties#asyncCredentialsUpdate documentation #1011

Merged

Conversation

MatejNedic
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Jan 3, 2024
@maciejwalkowiak
Copy link
Contributor

When we are here, perhaps StsProperties#isAsyncCredentialsUpdate field should be renamed to asyncCredentialsUpdate and i guess this will make javadoc properly appear in configprops asciidoc.

@github-actions github-actions bot added the component: core Core functionality related issue label Jan 5, 2024
@maciejwalkowiak maciejwalkowiak merged commit 249172c into awspring:main Jan 14, 2024
4 checks passed
@maciejwalkowiak maciejwalkowiak modified the milestones: 3.1.1, 3.1.2 Jan 14, 2024
@maciejwalkowiak maciejwalkowiak changed the title Fix documentation Fix StsProperties#asyncCredentialsUpdate documentation Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Core functionality related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants