Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ServiceConnection support. #1075

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Add @ServiceConnection support. #1075

merged 7 commits into from
Mar 18, 2024

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Mar 6, 2024

Fixes #793.

Added support for @ServiceConnection on LocalstackContainer.

@SpringBootTest
class AppTest {

	@TestConfiguration
	static class AppConfiguration {

		@Bean
		@ServiceConnection
		LocalStackContainer localStackContainer() {
			return new LocalStackContainer(DockerImageName.parse("localstack/localstack:3.2.0"));
		}
	}

        // all clients are automatically configured to connect to LocalStack container
}

@github-actions github-actions bot added component: cloudwatch CloudWatch integration related issue component: core Core functionality related issue component: dynamodb DynamoDB integration related issue component: s3 S3 integration related issue component: ses SES integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: dependency-upgrade Dependency version bump labels Mar 6, 2024
@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review March 6, 2024 15:23
@maciejwalkowiak maciejwalkowiak added this to the 3.2 milestone Mar 6, 2024
Copy link
Member

@MatejNedic MatejNedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome can't wait to use it :) !

@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Mar 18, 2024
@maciejwalkowiak maciejwalkowiak merged commit 4844659 into main Mar 18, 2024
4 checks passed
@maciejwalkowiak maciejwalkowiak deleted the gh-793 branch March 18, 2024 09:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.2% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cloudwatch CloudWatch integration related issue component: core Core functionality related issue component: dynamodb DynamoDB integration related issue component: s3 S3 integration related issue component: ses SES integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: dependency-upgrade Dependency version bump type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ConnectionsDetails and ServiceConnections for Spring Boot 3.1
2 participants