Fix Acknowledgement Graceful Shutdown #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BatchingAcknowledgementProcessor had a racing condition where if the processor was stopped while there where still messages to ack in the main ack queue, it would stop polling and fail to acknowledge such messages even if there was time left for it. This commit fixes this and adds relevant test coverage.
tomazfernandes
requested review from
maciejwalkowiak and
MatejNedic
as code owners
maciejwalkowiak
approved these changes
Mar 10, 2024
MatejNedic
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchingAcknowledgementProcessor had a racing condition where if the processor was stopped while there where still messages to ack in the main ack queue, it would stop polling and fail to acknowledge such messages even if there was time left for it.
This commit fixes this and adds relevant test coverage.
📢 Type of change
💚 How did you test it?
Automated tests
📝 Checklist