Added trailing slash to parameter store examples #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trailing slash is required to avoid a leading dot in the property name. For example, if the parameter is named `/config/spring/message` and the `spring.config.import` property is `aws-parameterstore:/config/spring`, then the resulting property in the Spring environment will be `.message`. Instead, the property should be `message`, so the `spring.config.import` property should be `aws-parameterstore:/config/spring/` Fixes awspring#1058
thelateperseus
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
the
type: documentation
maciejwalkowiak
added
the
component: parameter-store
maciejwalkowiak
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing slash is required to avoid a leading dot in the property name. For example, if the parameter is named
/config/spring/messageand thespring.config.importproperty isaws-parameterstore:/config/spring, then the resulting property in the Spring environment will be.message. Instead, the property should bemessage, so thespring.config.importproperty should beaws-parameterstore:/config/spring/Fixes #1058, #923