#595 migrate to sesv2 #1336
Open
#595 migrate to sesv2 #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-kovacs
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: ses
|
@dominik-kovacs thanks for a PR. To avoid breaking changes, we need to keep the current integration working. Perhaps it's makes sense to have a new module for v2? @MatejNedic any opinions? |
|
The only breaking change I encountered was merging we could keep all 3 and deprecate sourceArn and fromArn
|
|
I would move it to a new module as well. If someone does not want to migrate sdk, it is better if you ask me. This is major change lets wait few versions before deprecating old module. How does this sound? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Migration of AWS SES from v1 to v2
💡 Motivation and Context
Amazon SES API v1 accepts messages up to 10MB in size including any images and attachments that are part of the message. SES API v2 accepts up to 40MB.
Issue #595
💚 How did you test it?
Unit tests
I don't have localstack pro, so no integration tests
📝 Checklist
🔮 Next steps