[WIP] Spring Cloud AWS w/ AWS SDK v2 #241
Conversation
| <dependency> | ||
| <groupId>io.awspring.cloud</groupId> | ||
| <artifactId>spring-cloud-aws-v3-messaging</artifactId> | ||
| <version>2.3.0-RC2</version> |
| * @author Gleb Schukin | ||
| * @author Bernardo Martins | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Should we delete all @deprecated stuff? After all, it's a Major release
| @@ -0,0 +1,37 @@ | |||
| package io.awspring.cloud.v3.it; | |||
There was a problem hiding this comment.
@maciejwalkowiak , can you please review this one?
| @@ -0,0 +1,19 @@ | |||
| package io.awspring.cloud.v3.it; | |||
There was a problem hiding this comment.
@maciejwalkowiak , can you please review this one?
|
@driverpt the plan is not only to migrate to AWS SDK v2 but also take this chance to revisit all the concepts and integrations we have. Spring Cloud AWS was created in 2013, AWS has changed a lot since then and some integrations or some patterns do not make sense any longer. I feel really bad for closing this PR as you have put a lot of work into it, but we can't and don't want to migrate just like that. |
|
@maciejwalkowiak , I think we should start simple. 1-1 Port and go from there. Otherwise we'll never get there. "Continuous Improvement is better than delayed Perfection". I started off by removing all XML and Can we at least add AutoConfig for all AWS Clients? They all follow the same patterns. |
|
@maciejwalkowiak , am i going to be left out here? Seems to me that you're not willing to accept any contributions. Is this the case? |
|
Of course we do accept contributions (see commit history) but 3.x is not yet in the state when we can easily accept contributions. Keep in mind that submitting PR is one thing, we are later responsible for maintaining anything that got merged. |
|
Alright, but can we be included in the development? I still think we should first migrate what we currently have as-is refactored for the AWS SDK v2 clients, and then improve it |
|
We have just closed 2.3.4 and 2.4.0. Now we switch focus to 3.x again and come up with guidelines for contributors. |
|
It would be nice if you actually accepted contributions, instead of turning down every single PR regarding 3.0.x with no discussion whatsoever and there is plenty of people happy to contribute with ideas and new concepts. I just find it a lack of respect that I tried to add new and simpler ways of testing and you just simply dismissed it without even looking at it. |
|
Once we bring 3.x to the state where we can accept contributions we will be more than happy to accept contributions. |
📢 Type of change
📜 Description
1-1 Port for Spring Cloud AWS messaging
💡 Motivation and Context
#20
💚 How did you test it?
Still refactoring tests and adding integration tests
📝 Checklist
🔮 Next steps