Adds array properties support to parameter store. (#245) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmpestano
requested review from
eddumelendez,
maciejwalkowiak and
MatejNedic
as code owners
github-actions
bot
added
component: parameter-store
maciejwalkowiak
added
type: enhancement
github-actions
bot
added
the
type: documentation
MatejNedic
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
@rmpestano thanks for your contribution!
It looks good to me. Just one more thing are you willing to add this scenario to our samples here? If you don't want to I will do it.
Hey @MatejNedic, thank you for reviewing! I can add the scenario no worries, I let you know if I need any help on that. |
|
I've added a simple example to the sample app, let me know if you want a more elaborated one like here or if anything else is needed. Cheers! |
maciejwalkowiak
approved these changes
Mar 7, 2022
.../awspring/cloud/autoconfigure/paramstore/ParameterStoreConfigDataLoaderIntegrationTests.java
Show resolved
Hide resolved
deki
pushed a commit
to deki/spring-cloud-aws
that referenced
this pull request
Sep 21, 2023
deki
pushed a commit
to deki/spring-cloud-aws
that referenced
this pull request
Sep 21, 2023
maciejwalkowiak
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This is a draft PR, the approach still needs to be discussed. Right now it's replacing the property names that follow the format
_INDEX_by[INDEX]💡 Motivation and Context
The main idea is to be able to represent array properties in aws parameter store params names, details in #245
💚 How did you test it?
📝 Checklist
It can break applications that haveIt shouldn't break any existing apps as we changed only the internal representation of how we store list properties._ANY INTEGER_pattern in their parameter store param names🔮 Next steps