New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AwsClientCustomizer to handle asyncHttpClientBuilder properly #875

Merged

maciejwalkowiak merged 1 commit into awspring:main from mokamoto12:fix-aws-client-customizer

Nov 4, 2023

Contributor

mokamoto12 commented Aug 30, 2023 •

edited

Loading

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

There seems to be an error in this line.
https://github.com/awspring/spring-cloud-aws/blob/v3.0.2/spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/core/AwsClientCustomizer.java#L76

💡 Motivation and Context

Bug fixed.

💚 How did you test it?

Unit testing was performed.

📝 Checklist

I reviewed submitted code
I added tests to verify changes
I updated reference documentation to reflect the change
All tests passing
No breaking changes

🔮 Next steps


          Fixed AwsClientCustomizer to handle asyncHttpClientBuilder properly

e50efb0

mokamoto12 requested review from maciejwalkowiak, MatejNedic and tomazfernandes as code owners

August 30, 2023 00:27

github-actions bot added the component: core label

MatejNedic self-assigned this

maciejwalkowiak approved these changes

View reviewed changes

maciejwalkowiak added this to the 3.0.3 milestone

maciejwalkowiak merged commit 3c793be into awspring:main

Contributor

maciejwalkowiak commented Nov 4, 2023

Thanks @mokamoto12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: core