Configure DynamoDb TableSchema as a bean #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: dynamodb
| private final List<TableSchema<?>> tableSchemas; | ||
| private final Map<String, TableSchema> tableSchemaCache = new ConcurrentHashMap<>(); | ||
|
|
||
| DefaultDynamoDbTableResolver() { |
There was a problem hiding this comment.
Just curious - what is this constructor for, with package private visibility?
spring-cloud-aws-dynamodb/src/main/java/io/awspring/cloud/dynamodb/DynamoDbTableResolver.java
Outdated
Show resolved
Hide resolved
| this.tableSchemas = tableSchemas; | ||
| } | ||
|
|
||
| public <T> TableSchema<T> resolveTableSchema(Class<T> clazz) { |
There was a problem hiding this comment.
I see this method was added to the interface, maybe add @Override?
| public <T> TableSchema<T> resolveTableSchema(Class<T> clazz) { | ||
| String tableName = tableNameResolver.resolve(clazz); | ||
| return tableSchemaCache.computeIfAbsent(tableName, | ||
| entityClassName -> tableSchemas.stream().filter(it -> it.itemType().rawClass().equals(clazz)) |
There was a problem hiding this comment.
If we're doing lookups by matching Class, maybe a better way to store this would be in a Map<Class, TableSchema>? We'd iterate it only once and have O(1) lookups afterwards.
There was a problem hiding this comment.
Done, and it actually opened my mind for simpler design.
|
thanks @tomazfernandes! now i think it is much better and no breaking changes. @MatejNedic can you take a look? |
MatejNedic
requested changes
Nov 22, 2023
| @@ -115,17 +117,23 @@ public DynamoDbEnhancedClient dynamoDbEnhancedClient(DynamoDbClient dynamoDbClie | |||
| return DynamoDbEnhancedClient.builder().dynamoDbClient(dynamoDbClient).build(); | |||
| } | |||
|
|
|||
| @ConditionalOnMissingBean(DynamoDbTableNameResolver.class) | |||
There was a problem hiding this comment.
Suggested change
| @ConditionalOnMissingBean(DynamoDbTableNameResolver.class) | |
| @ConditionalOnMissingBean(DynamoDbTableSchemaResolver.class) |
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
maciejwalkowiak
added a commit
that referenced
this pull request
Dec 10, 2023
Fixes #674 Co-authored-by: Gladîș Vladlen <gladis.vladlen+github@gmail.com>
maciejwalkowiak
added a commit
that referenced
this pull request
Dec 10, 2023
Fixes #674 Co-authored-by: Gladîș Vladlen <gladis.vladlen+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674