Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stdlib_io tests to test-drive #87

Merged
merged 17 commits into from
Sep 3, 2021
Merged

Port stdlib_io tests to test-drive #87

merged 17 commits into from
Sep 3, 2021

Conversation

milancurcic
Copy link

This was a fun exercise. All stdlib_io tests now run under the new testing framework. loadtxt* tests were re-written as the old tests were only printing to screen and not checking values. However, they do depend on savetxt for round-tripping the data, so neither test_savetxt and test_loadtxt are isolated from each other.

@milancurcic
Copy link
Author

test_loadtxt fails with ifort because of the default formatting used in savetxt, which is not portable. I'll open a separate issue and patch in fortran-lang/stdlib.

Copy link
Owner

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_outpath() routine will clash with the logic used in the testing framework to select the unit test to run. At the moment this doesn't matter, but is an issue we have to fix when we start merging the suites.

@awvwgk awvwgk merged commit 87d6dc3 into awvwgk:test Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants