[WIP] refactor/plugin system #43
Conversation
|
I started experimenting with a possible implementation of the plugin system for a while ago. I will reintegrate after #42 has been merged. @axe312ger Feedback would be awesome since you have better experience with node compared to me :) Also I am pretty sure you have something in your mind as well. |
| @@ -0,0 +1,29 @@ | |||
| const encodeBase64 = rawSVG => Buffer.from(rawSVG).toString('base64') | |||
There was a problem hiding this comment.
I wonder if we should remove this completely. Base64 is just bad for compression. See data here:
There was a problem hiding this comment.
@technopagan had something about that I can agree on that <3 also the wrapping we do, not sure if it is useful at all.
There was a problem hiding this comment.
Actually I expected the CLI to spit out a SVG file, not an Image tag 🙈
We could keep base64 as plugin and use the mini data uri's as default for encoding.
src/sqip.js
Outdated
| const SVGPlugin = require('./plugins/svg') | ||
| const SVGOPlugin = require('./plugins/svgo') | ||
| const PrimitivePlugin = require('./plugins/primitive') | ||
| const Base64EncodePlugin = require('./plugins/base64') |
There was a problem hiding this comment.
i wonder if we should at least export them as separate packages with something like https://github.com/lerna/lerna
There was a problem hiding this comment.
Good point, we are actually using it for melody at trivago.
|
@axe312ger @technopagan Hey I am sorry I cannot find any more time to continue on it currently. A lot has been happening since last 6 months (Personal stuff, work change etc.). I feel like I am blocking everything. Please feel free to take over this, or build a new one. I will still try to do contribute later, but cannot find free time anymore. Sorry 🤷♂️ |
|
@hafizalfaza this is something you could have a look at. Rebase, fix conflicts and then check how much of @efegurkan code we can use. I guess it is in a pretty good state. |
Rewrite and rearrange utilities into plugins. -Create sqip.js to run plugins over the input file -Turn SVG, SVGO, primitive and base64 as plugins -Move loadSVG into utils/helpers
axe312ger
force-pushed
the
refactor/plugin-system
branch
from
023be72 to
8bd23d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 90.72% 84.61% -6.11%
==========================================
Files 5 7 +2
Lines 97 117 +20
Branches 11 14 +3
==========================================
+ Hits 88 99 +11
- Misses 8 15 +7
- Partials 1 3 +2
Continue to review full report at Codecov.
|
|
code went into core via #55 |
Rewrite and rearrange utilities into plugins.
-Create sqip.js to run plugins over the input file
-Turn SVG, SVGO, primitive and base64 as plugins
-Move loadSVG into utils/helpers