feat(sui): request tokens from faucet only if recipient balance is below a specific amount #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is below a specific amount
added 2 commits
September 24, 2024 00:33
milapsheth
approved these changes
Sep 23, 2024
milapsheth
reviewed
Sep 24, 2024
milapsheth
reviewed
Sep 24, 2024
|
|
||
| if (balance >= Number(options.minBalance)) { | ||
| printWarn('Wallet balance above minimum, skipping faucet request'); | ||
| process.exit(0); |
There was a problem hiding this comment.
should return from this method and not exit the whole process
milapsheth
reviewed
Sep 24, 2024
|
|
||
| const coins = await client.getBalance({ owner: keypair.toSuiAddress() }); | ||
| async function printWalletInfo(wallet, client, chain, options) { | ||
| const owner = |
There was a problem hiding this comment.
walletAddress perhaps instead of owner
milapsheth
reviewed
Sep 24, 2024
| const coins = await client.getBalance({ owner: keypair.toSuiAddress() }); | ||
| async function printWalletInfo(wallet, client, chain, options) { | ||
| const owner = | ||
| wallet instanceof Ed25519Keypair || wallet instanceof Secp256k1Keypair || wallet instanceof Secp256r1Keypair |
There was a problem hiding this comment.
is there a base KeyPair class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.