-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add query transaction status #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2355863 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SGiaccobasso
approved these changes
Jun 20, 2024
SGiaccobasso
added a commit
that referenced
this pull request
Jun 27, 2024
* feat:add-tx-recovery (#363) * chore: init manualRelayToDestChain * chore: pending work and disable husky * feat: add `AxelarRecoveryApiClient` * chore: add axelar recovery api urls * chore: add createAxelarBroadcastClient * feat: implement confirm step * feat: implement sign tx flow * feat: improve sign tx * feat: implement route message * chore: add signEvmTx to axelar-recovery client * chore: implement signGatewayApprove tx * chore: refactor error for each recovery step * chore: fix build error * chore: add retry * chore: add built path to gitignore * chore: returns early if fail to proceed * docs(changeset): add tx recovery * docs(changeset): Add a tx recovery feature * feat: implement escapeAfterConfirm * chore: make options optional * chore: add tests * chore: moving files and folders * chore: check for tx status first * chore: remove unnecessary check * chore: fix checking finalized block issue * chore: fix error msg * chore: refactor recovery methods * chore: add test for axelar confirm tx * chore: add tests for axelarConfirmTx * chore: remove unused import * chore: add more assertion axelarConfirmTx * chore: add tests for axelar sign tx * chore: add evm gateway approve test * chore: fix sign commands * chore: remove execute tx signing from backend * chore: remove unused import * chore: remove the signEvmTx command from axelar-recovery api * chore: move getWalletClient to common folder * chore: use wallet client to sendRawTransaction * chore: implement response mapping * chore: fix build error * chore: implement recovery tests * chore: update isomorphic test * chore: fix tests * chore: fix tests * chore: add messageId and txLogIndex to params * chore: remove txEventIndex * chore: fix import * chore: skip manual test * chore: fix test expect * chore: uncomment husky * chore: remove outdated changeset * chore: add changeset * chore: typo * feat: add lcd urls to core package * feat: add stargate connect function with fallback to other rpc urls * chore: fix tests * chore: update changeset * chore: fix error in deposit address * chore: fix wrong type * chore: extract helper function 'shouldAbortRecovery' * chore: separate actions and types for axelar txs * chore: add more reasons to retry batch commands * chore: added more tests and fix error * chore: remove sign tx from evm to ibc * chore: move batch commands query in sign commands inside try block * chore: move batch commands query to the try block * chore: remove undefined * chore: apply changesets (#378) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add query transaction status (#379) * feat: implement queryTransactionStatus * chore: update express_executed type * chore: add tests * docs(changeset): chore: add queryTransactionStatus to transaction-recovery package * chore: update function doc * feat: redesign (#377) * feat: update colors * feat: update colors * feat: add clash grotesk font and set it as primary font * feat: update font weights * feat: update font weights ui package * feat: animated bg * feat: animated bg in ui package * feat: mobile and light mode improvements * feat: mobile and light mode improvements ui package * fix: video bg on mobile * fix: chain selector position on mobile * fix: remove unused page and use tabs in deployments table * fix: tabs position to match other pages * fix: get deployments query * fix: show theme selector in sidebar * fix: text colors token page --------- Co-authored-by: Santiago Giaccobasso <santigiacco@192.168.1.4> Co-authored-by: Santiago Giaccobasso <santigiacco@192.168.0.104> Co-authored-by: Santiago Giaccobasso <santigiacco@Santiagos-MacBook-Pro.local> * chore: apply changesets (#381) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix type error (#383) * chore: add dev guideline (#384) * chore: apply changesets (#385) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: npty <78221556+npty@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Santiago Giaccobasso <santigiacco@192.168.1.4> Co-authored-by: Santiago Giaccobasso <santigiacco@192.168.0.104> Co-authored-by: Santiago Giaccobasso <santigiacco@Santiagos-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-4225
Migrated the
queryTransactionStatus
function from SDK v1.There're some difference between response in v1 and v2 as follows
Response in V1
✅ Success:
❌ Fail
Response in V2 (This package)
✅ Success
❌ Fail