Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve the existing known hosts information when ssh-keyscan encounters an issue #9

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

zeshanziya
Copy link
Contributor

parse existing known_hosts file and if ssh-keyscan command fails for any domain, we use the existing record for that domain. So this way, we will preserve the existing known hosts information when ssh-keyscan encounters an issue.

Copy link
Member

@hussainweb hussainweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I just wish the known_hosts change was left in a separate PR. But this is not a dealbreaker.

@hussainweb hussainweb merged commit 6c51ae1 into axelerant:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants