fix: update ignore diagnostics code. close #41

axetroy · Feb 9, 2020 · 34e6c10 · 34e6c10
1 parent 8c4cc59
commit 34e6c10
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/server/src/diagnostics.ts b/server/src/diagnostics.ts
@@ -31,7 +31,7 @@ enum DiagnosticCode {
   LockStdVersion = 1006
 }
 
-const FixItems: { [code: number]: Fix } = {
+const FixItems: { [code: number]: Fix; } = {
   [DiagnosticCode.PreferHTTPS]: {
     title: localize("diagnostic.fix.use_HTTPS_module"),
     command: "deno._use_https_module"
@@ -124,7 +124,7 @@ export class Diagnostics {
       return [];
     }
 
-    let sourceFile;
+    let sourceFile: ts.SourceFile | void;
     try {
       // Parse a file
       sourceFile = ts.createSourceFile(
@@ -134,6 +134,7 @@ export class Diagnostics {
         false,
         ts.ScriptKind.TSX
       );
+      sourceFile.fileName;
     } catch (err) {
       return [];
     }
@@ -256,7 +257,11 @@ export class Diagnostics {
         }
       }
 
-      const module = await deno.resolveModule(importMaps, dir, moduleNode.text);
+      const module = await deno.resolveModule(
+        importMaps,
+        dir,
+        moduleNode.text
+      );
 
       if (!ts.sys.fileExists(module.filepath)) {
         diagnosticsForThisDocument.push(

diff --git a/typescript-deno-plugin/src/module_resolver.ts b/typescript-deno-plugin/src/module_resolver.ts
@@ -29,7 +29,7 @@ export class ModuleResolver {
     private readonly file: string,
     private readonly logger: Logger,
     private readonly workspaceDir: string,
-    readonly importMapsFile?: string
+    importMapsFile?: string
   ) {
     if (importMapsFile) {
       this.importMaps = this.resolveImportMaps(importMapsFile);

diff --git a/typescript-deno-plugin/src/plugin.ts b/typescript-deno-plugin/src/plugin.ts
@@ -126,8 +126,10 @@ export class DenoPlugin implements ts_module.server.PluginModule {
       }
 
       const ignoreCodeMapInDeno: { [k: number]: boolean; } = {
-        // 2691: true, // can not import module which end with `.ts`
-        1308: true // support top level await 只允许在异步函数中使用 "await" 表达式
+        2691: true, // can not import module which end with `.ts`
+        1308: true, // support top level await below typescript 3.8.0
+        1378: true, // support top level await in typescript^3.8.0
+        1103: true // support `for of await`
       };
 
       return diagnostics.filter(v => {