fix: add more test case for import_map. ref #132

__test__/import_maps/empty_import_map.json

@@ -0,0 +1,3 @@
+{
+ "imports": {}
+}

__test__/import_maps/import_map_not_valid_field.json

@@ -0,0 +1,3 @@
+{
+ "imports": []
+}

core/import_map.test.ts

@@ -7,7 +7,6 @@ const TEST_DIR = path.join(__dirname, "..", "__test__");
 test("core / import_map", async () => {
  const mockWorkspaceDir = path.join(TEST_DIR, "import_maps");
 
- const invalidImportMapFilepath = path.join(mockWorkspaceDir, "invalid.json");
  const validImportMapFilepath = path.join(mockWorkspaceDir, "import_map.json");
 
  expect(ImportMap.create(validImportMapFilepath).toJSON()).toEqual({
@@ -29,18 +28,50 @@ test("core / import_map", async () => {
  path.join(mockWorkspaceDir, "src", "relative", "path", "to", "mod.ts")
  );
 
- expect(ImportMap.create(invalidImportMapFilepath).toJSON()).toEqual({});
-
  const importMap = await ImportMap.create(validImportMapFilepath);
 
  for (const [prefix, moduleName] of importMap) {
  expect(typeof prefix).toBe("string");
  expect(typeof moduleName).toBe("string");
  expect(prefix).not.toEqual(moduleName);
  }
+});
 
- // if import_map not exist
+test("core / import_map if import_map file not exist", async () => {
  expect(
  ImportMap.create(path.join(__dirname, "path", "not", "exist")).toJSON()
  ).toEqual({});
 });
+
+test("core / import_map if invalid import_map", async () => {
+ const mockWorkspaceDir = path.join(TEST_DIR, "import_maps");
+
+ const filepath = path.join(mockWorkspaceDir, "invalid.json");
+
+ const importMap = ImportMap.create(filepath);
+
+ expect(importMap.toJSON()).toEqual({});
+});
+
+test("core / import_map if it is empty", async () => {
+ const mockWorkspaceDir = path.join(TEST_DIR, "import_maps");
+
+ const filepath = path.join(mockWorkspaceDir, "empty_import_map.json");
+
+ const importMap = ImportMap.create(filepath);
+
+ expect(importMap.toJSON()).toEqual({});
+});
+
+test("core / import_map if imports field not an Object", async () => {
+ const mockWorkspaceDir = path.join(TEST_DIR, "import_maps");
+
+ const filepath = path.join(
+ mockWorkspaceDir,
+ "import_map_not_valid_field.json"
+ );
+
+ const importMap = ImportMap.create(filepath);
+
+ expect(importMap.toJSON()).toEqual({});
+});

core/import_map.ts

@@ -39,6 +39,15 @@ export class ImportMap implements ImportMapInterface {
 
  try {
  importMap = JSON.parse(importMapContent || "");
+
+ // Make sure `importMap.imports` is a key-value object
+ // Otherwise, an exception may be thrown
+ if (
+ Object.prototype.toString.call(importMap.imports) !==
+ "[object Object]"
+ ) {
+ importMap.imports = {};
+ }
  } catch {
  importMap.imports = {};
  }