chore: check IsFinalized on callback function to prevent creating red…

…undant tasks
axieinfinity · Aug 16, 2023 · d37561b · d37561b
1 parent 4c8143a
commit d37561b
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/cmd/bridge/config.go b/cmd/bridge/config.go
@@ -0,0 +1 @@
+package main
diff --git a/cmd/bridge/config_test.go b/cmd/bridge/config_test.go
@@ -0,0 +1 @@
+package main
diff --git a/listener/ronin.go b/listener/ronin.go
@@ -309,6 +309,20 @@ func (l *RoninListener) RandomSeedRequestedCallback(fromChainId *big.Int, tx bri
 	if err = l.utilsWrapper.UnpackLog(*contractAbi, event, "RandomSeedRequested", data); err != nil {
 		return err
 	}
+	// call to contract to see if the request is finalized or not?
+	caller, err := contract.NewRoninVRFCoordinatorCaller(common.HexToAddress(task.VRFConfig.ContractAddress), l.client)
+	if err != nil {
+		log.Error("error while init new VRF caller", "err", err, "contractAddress", task.VRFConfig.ContractAddress)
+		return err
+	}
+	isFinalized, err := task.IsFinalized(caller, event.ReqHash)
+	if err != nil {
+		log.Error("error while checking random request is finalized or not", "err", err)
+		return err
+	}
+	if isFinalized {
+		return nil
+	}
 	// get chainID
 	chainId, err := l.GetChainID()
 	if err != nil {

diff --git a/task/vrf.go b/task/vrf.go
@@ -17,7 +17,6 @@ import (
 
 func (r *task) sendFullFillRandomSeedTransactions(task *models.Task) (doneTasks, processingTasks, failedTasks []*models.Task, tx *ethtypes.Transaction) {
 	log.Info("[RoninTask][sendFullFillRandomSeedTransactions] Processing task")
-	// check whether current operator is assigned or not
 	var (
 		err         error
 		event       = new(contract.RoninVRFCoordinatorRandomSeedRequested)
@@ -39,7 +38,7 @@ func (r *task) sendFullFillRandomSeedTransactions(task *models.Task) (doneTasks,
 		goto ERROR
 	}
 	// req is finalized, GOTO update done
-	finalized, err = isFinalized(caller, event.ReqHash)
+	finalized, err = IsFinalized(caller, event.ReqHash)
 	if err != nil {
 		goto ERROR
 	}
@@ -119,7 +118,7 @@ func isAssigned(signer utils.ISign, assignee common.Address) bool {
 	return true
 }
 
-func isFinalized(caller *contract.RoninVRFCoordinatorCaller, req [32]byte) (bool, error) {
+func IsFinalized(caller *contract.RoninVRFCoordinatorCaller, req [32]byte) (bool, error) {
 	result, err := caller.RequestFinalized(nil, req)
 	if err != nil {
 		return false, err