Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test + script: remove address precomputation, setup test for withdrawal #20

Merged
merged 11 commits into from
Jan 22, 2024

Conversation

huyhuynh3103
Copy link
Collaborator

@huyhuynh3103 huyhuynh3103 commented Jan 21, 2024

Description

This PR mainly removes the precomputation of addresses before deployment because it is difficult to maintain later.

  • Set up two local chains named RoninLocal and EthLocal in integration testing to better understand how the bridge works in reality.
  • Run two local chains in CI before testing; by default, Github will help us terminate these processes automatically at the end of workflow process.
  • Deploy all contracts raw first and initialize later to ensure that all contracts are set up correctly with each other and can be reused in the future.

Command to start these local chains:

  • EthLocal: anvil --chain-id 2 --port 8547
  • RoninLocal: anvil --chain-id 2024 --port 8546

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@huyhuynh3103 huyhuynh3103 changed the title test + script: Remove address precomputation when setting up unit tests test + script: remove address precomputation Jan 22, 2024
@nxqbao nxqbao changed the title test + script: remove address precomputation test + script: remove address precomputation, setup test for withdrawal Jan 22, 2024
@huyhuynh3103 huyhuynh3103 merged commit a0f6096 into release/v0.1.0 Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants