Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: map pixel token and change governor axiechat #24

Merged
merged 8 commits into from
Jan 31, 2024
Merged

proposal: map pixel token and change governor axiechat #24

merged 8 commits into from
Jan 31, 2024

Conversation

nxqbao
Copy link

@nxqbao nxqbao commented Jan 31, 2024 •
edited by ducthotran2010
Loading

Command

./run.sh script/20240131-maptoken-pixel/20240131-maptoken-pixel-mainchain.s.sol -f ronin-mainnet --legacy -vvvv  --trezor 0xe880802580a1fbdeF67ACe39D1B21c5b2C74f059 --broadcast

./run.sh script/20240131-maptoken-pixel/20240131-maptoken-pixel-roninchain.s.sol -f ronin-mainnet --legacy -vvvv  --trezor 0xe880802580a1fbdeF67ACe39D1B21c5b2C74f059 --broadcast

@nxqbao nxqbao changed the title Proposal/map pixel token and change governor axiechat proposal: map pixel token and change governor axiechat Jan 31, 2024
minh-bq
minh-bq approved these changes Jan 31, 2024
View reviewed changes
Copy link

@minh-bq minh-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: some files miss newline at the end of file.
Overall, LGTM.

script/20240131-maptoken-pixel/20240131-maptoken-pixel-mainchain.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/maptoken-pixel-configs.s.sol Show resolved Hide resolved
ducthotran2010
ducthotran2010 reviewed Jan 31, 2024
View reviewed changes
Copy link

@ducthotran2010 ducthotran2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have some post-checks to ensure ppl could request deposit/withdrawal on Ethereum/Ronin?

script/20240131-maptoken-pixel/20240131-maptoken-pixel-mainchain.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/maptoken-pixel-configs.s.sol Outdated Show resolved Hide resolved
script/20240131-maptoken-pixel/maptoken-pixel-configs.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/maptoken-pixel-configs.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/maptoken-pixel-configs.s.sol Outdated Show resolved Hide resolved
script/20240131-maptoken-pixel/20240131-maptoken-pixel-mainchain.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/update-axiechat-config.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/update-axiechat-config.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/20240131-maptoken-pixel-roninchain.s.sol Show resolved Hide resolved
script/20240131-maptoken-pixel/20240131-maptoken-pixel-roninchain.s.sol Outdated Show resolved Hide resolved
@ducthotran2010 ducthotran2010 merged commit 111de60 into mainnet Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minh-bq minh-bq minh-bq approved these changes

@huyhuynh3103 huyhuynh3103 huyhuynh3103 approved these changes

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nxqbao @ducthotran2010 @huyhuynh3103 @minh-bq