ethstats: add coinbase to nodeInfo #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNK90
force-pushed
the
ethstats/add_coinbase_to_nodeInfo
branch
from
4970550
to
f74b6ec
Compare
DNK90
force-pushed
the
ethstats/add_coinbase_to_nodeInfo
branch
from
f74b6ec
to
3f920fe
Compare
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to serve new feature of ronin-stats (knowing coinbase of connected node), I've added coinbase which is get from eth.Etherbase() function.
Empty coinbase is still allowed in case nodes run without adding any account into account manager