all: introduce trie owner notion #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
force-pushed
the
trie-owner-notion
branch
from
8f93c3f
to
3420080
Compare
|
@Francesco4203 Could u put some description about the concept of trie owner here from go-ethereum team ? |
* cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se>
Francesco4203
force-pushed
the
trie-owner-notion
branch
from
3420080
to
8bd0193
Compare
@huyngopt1994 Added. |
| func newTriePrefetcher(db Database, root common.Hash, namespace string) *triePrefetcher { | ||
| prefix := triePrefetchMetricsPrefix + namespace | ||
| p := &triePrefetcher{ | ||
| db: db, | ||
| root: root, | ||
| fetchers: make(map[common.Hash]*subfetcher), // Active prefetchers use the fetchers map | ||
| fetchers: make(map[string]*subfetcher), // Active prefetchers use the fetchers map |
There was a problem hiding this comment.
func (p *triePrefetcher) trieID(owner common.Hash, root common.Hash) string {
return string(append(owner.Bytes(), root.Bytes()...))
}
so the new key will be changed from the root to string(append(owner.Bytes(), root.Bytes()...))
There was a problem hiding this comment.
| return &tracer{ | ||
| insert: insert, | ||
| delete: delete, | ||
| origin: origin, |
There was a problem hiding this comment.
then we will have the other PR for tracking this map data ?
huyngopt1994
approved these changes
Sep 4, 2024
|
LGTM, let merge to next Implementing. |
Francesco4203
merged commit b413887
into
axieinfinity:path-base-implementing
1 check passed
Francesco4203
added a commit
to Francesco4203/ronin
that referenced
this pull request
Sep 16, 2024
* cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
huyngopt1994
pushed a commit
that referenced
this pull request
Sep 17, 2024
* cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to:
prefetcher. Currently, each trie is represented by its root hash. There will be a case when two accounts have exactly the same storage information, and thus the same root hash of storage trie. Adding the owner information helps distinguishing them correctly, and each account has its own storage trie now.(t *Trie) Commit(), if the trie is clean (maybe committed earlier) and nothing-dirty-to-commit now, there might still be some resolved nodes (maybe retrieved earlier), but the tracer isReset(), so it will lose the information regarding those nodes. This PR set the root to its hash to ensure that all nodes are released afterCommit().