core, trie: rework trie commiter #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the commit procedure, introduce new struct called nodeSet for returning including all dirty nodes of a trie. Multiple nodeset will be merged to MergedNodeSet struct. then be submitted to in-memory database from block to block
| // Merge merges the provided dirty nodes of a trie into the set. The assumption | ||
| // is held that no duplicated set belonging to the same trie will be merged twice. | ||
| func (set *MergedNodeSet) Merge(other *NodeSet) error { | ||
| _, present := set.sets[other.owner] |
There was a problem hiding this comment.
Just concerning, account trie does not have owner (owner is empty), will this still work as expected?
There was a problem hiding this comment.
As I understood, The account trie will have the empty hash for the owner, but the StorageTrie will use the addrHash for it
// OpenStorageTrie opens the storage trie of an account.
func (db *cachingDB) OpenStorageTrie(addrHash, root common.Hash) (Trie, error) {
tr, err := trie.NewSecure(addrHash, root, db.db)
For account owner, the mergednodeset will be initiated and merged one time when comitting so it's safe for case duplicated.
// Write the account trie changes, measuing the amount of wasted time
var start time.Time
if metrics.EnabledExpensive {
start = time.Now()
}
root, nodeSet, err := s.trie.Commit(true)
if err != nil {
return common.Hash{}, err
}
Francesco4203
approved these changes
Sep 6, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Sep 16, 2024
* core, trie: rework trie commiter changed the commit procedure, introduce new struct called nodeSet for returning including all dirty nodes of a trie. Multiple nodeset will be merged to MergedNodeSet struct. then be submitted to in-memory database from block to block * trie,core: fix comments
huyngopt1994
added a commit
that referenced
this pull request
Sep 17, 2024
* core, trie: rework trie commiter changed the commit procedure, introduce new struct called nodeSet for returning including all dirty nodes of a trie. Multiple nodeset will be merged to MergedNodeSet struct. then be submitted to in-memory database from block to block * trie,core: fix comments
huyngopt1994
added a commit
that referenced
this pull request
Oct 25, 2024
* core, trie: rework trie commiter changed the commit procedure, introduce new struct called nodeSet for returning including all dirty nodes of a trie. Multiple nodeset will be merged to MergedNodeSet struct. then be submitted to in-memory database from block to block * trie,core: fix comments
huyngopt1994
added a commit
that referenced
this pull request
Nov 21, 2024
* core, trie: rework trie commiter changed the commit procedure, introduce new struct called nodeSet for returning including all dirty nodes of a trie. Multiple nodeset will be merged to MergedNodeSet struct. then be submitted to in-memory database from block to block * trie,core: fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference in ethereum/go-ethereum#25320.
It's implementing PR prepare for next implementing Path based.
this PR is submitted to adjust the commit procedure. Now all the dirty nodes of a trie will be encapsulated in a struct called nodeSet for return. Multiple nodeSets can be merged together as a MergedNodeSet. Eventually the MergedNodeSet will be submitted to in-memory database as a whole to represent the state transition from block to block.