all: rework genesis api #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible
Francesco4203
force-pushed
the
rework-genesis-api
branch
from
3e39d2a to
f5a3df0
Compare
* all: polish tests * core: apply feedback from Guillaume * core: fix comment
Francesco4203
force-pushed
the
rework-genesis-api
branch
from
f5a3df0 to
94f0fb7
Compare
|
Founding some places impacted to rewind logic here, maybe need to retest again after merging.
|
| genesis = DefaultGoerliGenesisBlock() | ||
| case params.SepoliaGenesisHash: | ||
| genesis = DefaultSepoliaGenesisBlock() | ||
| } |
There was a problem hiding this comment.
Could u recheck all params when recommit genesis to disk?
| statedb.SetState(addr, key, value) | ||
| } | ||
| } | ||
| root := statedb.IntermediateRoot(false) |
There was a problem hiding this comment.
Is it safe to remove the recalculated root in this line?
There was a problem hiding this comment.
root, err := g.Alloc.flush(db)
if err != nil {
panic(err)
}
The root is calculated by flush logic which is committed, so we don't need to callI IntermediateRoot here 🤔
|
I rechecked the logic of refactoring, seem it's safe for merging. LGTM. |
huyngopt1994
approved these changes
Sep 10, 2024
huyngopt1994
merged commit f69fce6
into
axieinfinity:path-base-implementing
1 check passed
Francesco4203
added a commit
to Francesco4203/ronin
that referenced
this pull request
Sep 16, 2024
* core: store genesis allocation and recommit them if necessary (#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible * all: cleanup the APIs for initializing genesis (#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
huyngopt1994
pushed a commit
that referenced
this pull request
Sep 17, 2024
* core: store genesis allocation and recommit them if necessary (#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible * all: cleanup the APIs for initializing genesis (#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
huyngopt1994
pushed a commit
that referenced
this pull request
Oct 25, 2024
* core: store genesis allocation and recommit them if necessary (#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible * all: cleanup the APIs for initializing genesis (#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
huyngopt1994
pushed a commit
that referenced
this pull request
Nov 21, 2024
* core: store genesis allocation and recommit them if necessary (#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible * all: cleanup the APIs for initializing genesis (#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to the 2 following PRs:
ToBlockis now only used to generate genesis block, since we haveFlushto write to dbGenesisBlockForTesting