Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: the ancient store implementing is now exported in package… #571

Conversation

huyngopt1994
Copy link
Collaborator

@huyngopt1994 huyngopt1994 commented Sep 12, 2024

Reference by ethereum/go-ethereum#24684 (Released in https://github.com/ethereum/go-ethereum/releases/tag/v1.10.18 )

  • Extend function AncientDataDir which can return the root directory of ancient store for opening some sub ancient
    stores(e.g. reverse diff freezer).
  • Rename the Interface name for consistency.
    ** AncientBatchReader -> AncientReader
    ** AncientReader -> AncientReaderOp
  • Make Freeze logic accessible and is used by other purpose not only storing ancient data, by create a Wrapper ChainFreezer and move out freeze function logic inside, keep minimal logic in Freeze struct
  • We will have other PRs related to ancient stuff rework based on this for implementing PB.

Mostly don't touch to the previous logic in freeze function although, we figured out some refactoring logic in this too.

… ethdb, can be used independently of the chain database, reference by commit 1941c5e
@huyngopt1994 huyngopt1994 merged commit d7a987e into path-base-implementing Sep 13, 2024
1 check passed
@huyngopt1994 huyngopt1994 deleted the make-freezer-implementing-exported-via-package-ethdb branch September 13, 2024 03:49
Francesco4203 pushed a commit to Francesco4203/ronin that referenced this pull request Sep 16, 2024
… ethdb, can be used independently of the chain database, reference by commit 1941c5e (axieinfinity#571)
huyngopt1994 added a commit that referenced this pull request Sep 17, 2024
… ethdb, can be used independently of the chain database, reference by commit 1941c5e (#571)
huyngopt1994 added a commit that referenced this pull request Oct 25, 2024
… ethdb, can be used independently of the chain database, reference by commit 1941c5e (#571)
huyngopt1994 added a commit that referenced this pull request Nov 21, 2024
… ethdb, can be used independently of the chain database, reference by commit 1941c5e (#571)
huyngopt1994 added a commit that referenced this pull request Feb 14, 2025
… ethdb, can be used independently of the chain database, reference by commit 1941c5e (#571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants