Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: prep for path-based trie storage #582

Conversation

Francesco4203
Copy link
Contributor

@Francesco4203 Francesco4203 commented Sep 25, 2024

Reference: ethereum/go-ethereum#26603

Changes:

  • Move trie storage logic to accessors_trie.go; separate the operations into old hash based (for backward compatibility) and new path based.
  • Delete NodeScheme. scheme is no longer an interface, but just a string, which will be checked by the new logic in accessors_trie.go to choose the corresponding operations.

@Francesco4203 Francesco4203 changed the base branch from master to path-base-implementing September 25, 2024 07:43
core/state/pruner/pruner.go Outdated Show resolved Hide resolved
les/downloader/downloader.go Show resolved Hide resolved
trie/sync.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@huyngopt1994 huyngopt1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyngopt1994 huyngopt1994 merged commit 6a1897a into axieinfinity:path-base-implementing Sep 26, 2024
1 check passed
Francesco4203 added a commit that referenced this pull request Oct 17, 2024
* all: prep for path-based trie storage

* all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
huyngopt1994 pushed a commit that referenced this pull request Oct 25, 2024
* all: prep for path-based trie storage

* all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
huyngopt1994 pushed a commit that referenced this pull request Nov 21, 2024
* all: prep for path-based trie storage

* all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants