-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: prep for path-based trie storage #582
Merged
huyngopt1994
merged 2 commits into
axieinfinity:path-base-implementing
from
Francesco4203:pathbased-trie-storage-prep
Sep 26, 2024
Merged
all: prep for path-based trie storage #582
huyngopt1994
merged 2 commits into
axieinfinity:path-base-implementing
from
Francesco4203:pathbased-trie-storage-prep
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
changed the base branch from
master
to
path-base-implementing
September 25, 2024 07:43
Francesco4203
force-pushed
the
pathbased-trie-storage-prep
branch
from
September 25, 2024 08:08
7d8cf25
to
76030b9
Compare
… check for length
Francesco4203
force-pushed
the
pathbased-trie-storage-prep
branch
from
September 25, 2024 17:27
f6bea7f
to
62992fe
Compare
huyngopt1994
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
huyngopt1994
merged commit Sep 26, 2024
6a1897a
into
axieinfinity:path-base-implementing
1 check passed
Francesco4203
added a commit
that referenced
this pull request
Oct 17, 2024
* all: prep for path-based trie storage * all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
huyngopt1994
pushed a commit
that referenced
this pull request
Oct 25, 2024
* all: prep for path-based trie storage * all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
huyngopt1994
pushed a commit
that referenced
this pull request
Nov 21, 2024
* all: prep for path-based trie storage * all: use rawdb.HasLegacyNode() to check for node existance instead of check for length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ethereum/go-ethereum#26603
Changes:
accessors_trie.go
; separate the operations into old hash based (for backward compatibility) and new path based.NodeScheme
.scheme
is no longer an interface, but just a string, which will be checked by the new logic inaccessors_trie.go
to choose the corresponding operations.