Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie: fix issue insert wrong path in stack trie and remove the offset… #604

Merged

Conversation

huyngopt1994
Copy link
Collaborator

@huyngopt1994 huyngopt1994 commented Oct 17, 2024

We got insert path issue in StackTrie in adhoc-cases.
Before:

WriteLegacyTrieNode hash 0xf54e1b8ecd2ef74d09b99be4335902a7f3fd51daf9ebe62abcfe5738f94cae07 path [1 8 2 4] scheme hashScheme xx 58
WriteLegacyTrieNode hash 0xebcf717022b16694103dc00d9c302e8acff97bb7fd3cdbbdbcba1d3d8640f65b path [1 8 1 5] scheme hashScheme xx 59
WriteLegacyTrieNode hash 0xbb682a41520d252f852fee6a58a8d4f9cf60b8651ae9477d8519b45e06ca925e path [1 8 2 9] scheme hashScheme xx 60

After:

WriteTrieNode path [1 8 2 4] hash 0xf54e1b8ecd2ef74d09b99be4335902a7f3fd51daf9ebe62abcfe5738f94cae07 scheme hashScheme
WriteTrieNode path [1 8 2 5] hash 0xebcf717022b16694103dc00d9c302e8acff97bb7fd3cdbbdbcba1d3d8640f65b scheme hashScheme
WriteTrieNode path [1 8 2 9] hash 0xbb682a41520d252f852fee6a58a8d4f9cf60b8651ae9477d8519b45e06ca925e scheme hashScheme

@huyngopt1994 huyngopt1994 merged commit 88c7ca4 into path-base-implementing Oct 17, 2024
1 check passed
@huyngopt1994 huyngopt1994 deleted the fix-wrong-path-when-inserting-stack-trie branch October 17, 2024 07:36
Francesco4203 pushed a commit that referenced this pull request Oct 17, 2024
huyngopt1994 added a commit that referenced this pull request Oct 25, 2024
huyngopt1994 added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant