Performance optimizations #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add readme add license
add linear combinators
…g-explorations#131) * fix: Force `VerifyFailure` to own the annotations map Since otherwise we can't move the `VerifyFailure` vec's confortably, and also, we're required to have a lot of lifetime annotations, it was decided to force the `VerifyFailure` to own the Annotation maps. This shouldn't be too harmful as it only triggers when testing. Resolves: privacy-scaling-explorations#130 * chore: Address clippy lints
…ure/multi-phase-mock-prover Call `synthesize` in `MockProver` multiple times to behave same as real prover
* apply `cargo clippy --fix`
* apply `cargo clippy --fix`
get (A', S') that is fully multi-threaded: this is a different algorithm than the original `permute_expression_pair_seq`
privacy-scaling-explorations#149) * feat: expose mod ule `permutation` and re-export `permutation::keygen::Assembly` * feat: derive `lone` for `permutation::keygen::Assembly` * feat: bump MSRV for `inferno`
In MockProver, replace all code that returns an error by an assert that panics instead of returning the error. This change aims to make it easier to debug circuit code bugs by getting backtraces.
…ing-explorations/feature/debug-assert-mock-prover feat(MockProver): replace errors by asserts
* test/unwrap_value: escape Value safety in the dev module * test/mock-prover-values: MockProver exposes the generated columns to tests * test/mock-prover-values: doc * mockprover-util: remove unwrap_value --------- Co-authored-by: Aurélien Nicolas <info@nau.re>
…#152) * feat: Parallelize `commit` blinder poly generator method Solves the concerns raised in privacy-scaling-explorations#151 related to the performance of the random poly generator inside of `commit`. Resolves: privacy-scaling-explorations#151 * chore: add `from_evals` for Polynomial * chore: add benches for commit_zk serial vs par * fix: Correct thread_seeds iter size * fix: Clippy * chore: apply review suggestions * fix: Inconsisten num of Scalars generated parallely This fix from @ed255 fixes an error on the code proposal which was rounding the num of Scalars to be generated and so, was producing failures. Co-authored-by: Edu <eduardsanou@posteo.net> * remove: legacy comments & code --------- Co-authored-by: Edu <eduardsanou@posteo.net>
jonathanpwang
pushed a commit
that referenced
this pull request
Oct 26, 2023
…tions#77 (#6) * Resolve taikoxyz/zkevm-circuits#77 * Please Clippy
jonathanpwang
added a commit
that referenced
this pull request
Nov 18, 2023
…17) * Resolve Prover optimization: memory reduction privacy-scaling-explorations#77 (#6) * Resolve taikoxyz/zkevm-circuits#77 * Please Clippy * fix: recursive FFT for lengths not `2^k, 2^extended_k` Also fixed some issue when multicore feature is not on. * fix: evaluation (cherry-pick https://github.com/scroll-tech/halo2-gpu/blob/a3019b047ad7d7119103f4d9df3fd33ce1429f95/halo2_proofs/src/plonk/evaluation.rs) * fix: `g_to_lagrange` uses inverse fft * Bump version since this is a breaking change to pk * chore: update halo2curves version --------- Co-authored-by: einar-taiko <126954546+einar-taiko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Brecht's FFT implementation
Add new parallel implementation for
permute_expression_pairfor lookup table