Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump intmap to 0.5.1 #45

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

paul1r
Copy link
Contributor

@paul1r paul1r commented Dec 18, 2024

The Loki team wishes to update hyperloglog, but requires a new version of the intmap library, so this can be compiled on a 32bit system. The current version of hyperloglog causes a build error because of this.

@lukasmalkmus
Copy link
Contributor

Hi @paul1r, I'm happy to accept and merge the PR but I wonder why intmap got promoted to a direct dependency? I expected something like this:

diff --git a/go.mod b/go.mod
index 7f91d81..2c22665 100644
--- a/go.mod
+++ b/go.mod
@@ -11,7 +11,7 @@ require (
 )
 
 require (
-	github.com/kamstrup/intmap v0.5.0 // indirect
+	github.com/kamstrup/intmap v0.5.1 // indirect
 	github.com/kr/pretty v0.3.0 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/rogpeppe/go-internal v1.9.0 // indirect

@paul1r
Copy link
Contributor Author

paul1r commented Dec 19, 2024

Hello @lukasmalkmus! I understand your question, and I had a question as to how it wasn't before, since it is directly imported here

@lukasmalkmus
Copy link
Contributor

Hello @lukasmalkmus! I understand your question, and I had a question as to how it wasn't before, since it is directly imported here

Hah, yes! You are absolutely right. I'm not to familiar with this repository so I wasn't aware it is actually imported. FYI, go mod tidy also notices this and correctly rewrites the go.mod to include intmap as a direct dependency.

Will merge.

@lukasmalkmus lukasmalkmus merged commit 30a916b into axiomhq:main Dec 20, 2024
@lukasmalkmus
Copy link
Contributor

lukasmalkmus commented Dec 20, 2024

@paul1r I just released v0.2.2 which includes your changes: https://github.com/axiomhq/hyperloglog/releases/tag/v0.2.2.

@paul1r
Copy link
Contributor Author

paul1r commented Dec 20, 2024

@lukasmalkmus Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants