Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust call to decode() for parameter change #52

Merged

Conversation

paul1r
Copy link
Contributor

@paul1r paul1r commented Feb 28, 2025

This commit removed an unused parameter from variableLengthList.decode(i).

When the underlying pull request was merged, there was a change needed to compressed.go to react to the parameter change. The testing before this fix shows:

go test ./...
# github.com/axiomhq/hyperloglog [github.com/axiomhq/hyperloglog.test]
./compressed.go:113:24: too many arguments in call to v.b.decode
	have (int, uint32)
	want (int)
FAIL	github.com/axiomhq/hyperloglog [build failed]
FAIL

After applying this fix:

go test ./... -count=1
ok  	github.com/axiomhq/hyperloglog	8.671s

@lukasmalkmus
Copy link
Contributor

My bad! Thanks for the fix.

This repository is in need for getting an updated CI :/

@lukasmalkmus lukasmalkmus merged commit d986218 into axiomhq:main Feb 28, 2025
@paul1r paul1r deleted the paul1r/update_test_for_decode_parameters branch February 28, 2025 20:15
@mgartner
Copy link
Contributor

mgartner commented Mar 1, 2025

Thanks for fixing this and sorry I missed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants