Expose XHR instance #200
Merged
Expose XHR instance #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mzabriskie. I hate to have to ask this, but could you take a look at this PR? We (the team behind Github.js) have switched to axios for our requests and this is the only piece left for the new release. In the previous versions we exposed the XHR istance, so not having it would cause a breaking change. |
Closed
|
Any chance to review this PR so that we can address #214? |
|
@mzabriskie ping. |
|
@AurelioDeRosa I'm fine merging this, but will you please do the same for the |
|
@mzabriskie is |
|
@AurelioDeRosa sorry, I just saw your response. Yes, |
Fixes gh-64
|
@mzabriskie Applied the change and also rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-64