Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host binding with hostname (instead TCP port) #213

Closed
nevergone opened this issue Nov 28, 2023 · 3 comments
Closed

Host binding with hostname (instead TCP port) #213

nevergone opened this issue Nov 28, 2023 · 3 comments

Comments

@nevergone
Copy link

Mailhog allow port binding with hostname (for ex. smtp:25), but mailpit not. Related code snippet (from config.go):

        re := regexp.MustCompile(`^((\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})|(\[([\da-fA-F:])+\])):\d+$`)
        if !re.MatchString(SMTPListen) {
                return errors.New("SMTP bind should be in the format of <ip>:<port>")
        }
        if !re.MatchString(HTTPListen) {
                return errors.New("HTTP bind should be in the format of <ip>:<port>")
        }
axllent added a commit that referenced this issue Dec 1, 2023
@axllent
Copy link
Owner

axllent commented Dec 1, 2023

Thanks for the feedback. I have made a change that will allow this, and will be included in the next release.

@axllent
Copy link
Owner

axllent commented Dec 1, 2023

This has been released in v1.10.2. Please confirm this works as expected?

@nevergone
Copy link
Author

Thanks, it's working! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants