Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX 'silverstripe/staticpublishqueue' user agent should be ignored #11

Merged
merged 1 commit into from
May 1, 2020

Conversation

mattclegg
Copy link
Contributor

When using the silverstripe/silverstripe-staticpublishqueue module the REQUEST_URI is updated so what's used for the request will be different from what is defined in $_SERVER['REQUEST_URI'].

As the REQUEST_URI can no longer be relied on then it makes more sense to ignore the user agent for staticpublishqueue.

ref; https://github.com/silverstripe/silverstripe-staticpublishqueue/blob/master/src/Publisher.php#L82-L101

@axllent axllent merged commit 6605252 into axllent:master May 1, 2020
@axllent
Copy link
Owner

axllent commented May 1, 2020

I don't generally like to include package-specific work-arounds, however this seems like the best solution here. Thanks for your input @mattclegg - I'll push through a new release shortly.

@mattclegg mattclegg deleted the 1588317374 branch May 2, 2020 12:48
@mattclegg
Copy link
Contributor Author

Yeah, I agree that it's not good to use a package-specific work-around. I've updated it to use a more generic approach; #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants