feat(verhandle): properly provide versioned semantics #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gankra
commented
Apr 8, 2024
Gankra
commented
- Require github tags to be parseable by axotag (or ignore the release)
- Provide a new LatestMaybePrerelease UpdateRequest mode
- Use Versions more freely in the code
- Prevent latest from downgrading
|
requires axodotdev/axotag#5 |
mistydemeo
approved these changes
Apr 8, 2024
| &release.tag_name, | ||
| )?; | ||
| let version = match announce.release { | ||
| axotag::ReleaseType::None => unreachable!("parse_tag should never return None"), |
There was a problem hiding this comment.
Right, from the changes in axodotdev/axotag#5?
There was a problem hiding this comment.
afaict it could in fact never be None, but the compiler literally yelled this at me after a refactor, so, now it's True (and I didn't want to redesign the API).
|
Checking the tests: it looks like this broke downgrading to a specific release. I'll take a look. |
* Require github tags to be parseable by axotag (or ignore the release) * Provide a new LatestMaybePrerelease UpdateRequest mode * Use Versions more freely in the code * Prevent latest from downgrading
mistydemeo
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.