Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos11 builds being used #1283

Closed
andrewdavidmackenzie opened this issue Aug 7, 2024 · 7 comments
Closed

macos11 builds being used #1283

andrewdavidmackenzie opened this issue Aug 7, 2024 · 7 comments

Comments

@andrewdavidmackenzie
Copy link

You can see from my release GH Action here that cargo-dist is generating build jobs for macos11.

These jobs are stalled waiting for runners.

But macos-11 runner images are deprecated (see here and elsewhere) and so this won't work.

I don't see in the book or release.yml how I can customize the OS I can use for mac/linux/windows platform?

I recently had to move other cross-platforms project builds to use macos-14, and I would like to do the same here.

@andrewdavidmackenzie
Copy link
Author

I just found this page in the book: https://opensource.axo.dev/cargo-dist/book/ci/customizing.html?highlight=macos#custom-runners

I see that says macos-12 is the default, but that's not my experience. I haven't customized the runner, and as you can see in links in above comment to GH Actions logs, it's using macos-11

@andrewdavidmackenzie
Copy link
Author

I'll leave this issue open (but feel free to close it), but I'd suggest you up the default macos runner from macos-11, as they do not work anymore.

@andrewdavidmackenzie
Copy link
Author

OK. So I changed my Cargo.toml file thus:

[workspace.metadata.dist.github-custom-runners]
aarch64-apple-darwin = "macos-14"
x86_64-apple-darwin = "macos-12"
x86_64-unknown-linux-gnu = "ubuntu-latest"
x86_64-pc-windows-msvc = "windows-latest"

and merged that PR, then pushed a tag again to trigger a release - but same behaviour:

Screenshot 2024-08-07 at 3 23 36 PM

@Gankra
Copy link
Member

Gankra commented Aug 7, 2024

You appear to be running cargo-dist 0.3.0, which is about a year old. Newer cargo-dist versions have increased the minimum runners (just install the latest release and cargo dist init again to auto-update/migrate everything).

@andrewdavidmackenzie
Copy link
Author

andrewdavidmackenzie commented Aug 7, 2024 via email

@andrewdavidmackenzie
Copy link
Author

Indeed! :-(
cargo-dist 0.19.1 installed!
Sorry for that, I was sure I had installed....

@andrewdavidmackenzie
Copy link
Author

re-trying. This looks like it might be a small (visual, at least) error...

Screenshot 2024-08-07 at 8 42 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants