fix(ci): always serialize upload_files #1420
Open
+107
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
fix-empty-upload
branch
from
29514e4
to
41d8485
Compare
While it's usually an error if we received a totally empty set of artifacts, it's possible in the global build job under a very specific set of conditions: * There are no installers, *and* * The source tarball was disabled In this case we need to make sure we still provide an upload_files array in the manifest so that we can always index into it. Fixes #1387.
mistydemeo
force-pushed
the
fix-empty-upload
branch
from
41d8485
to
4c66d7b
Compare
Gankra
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's usually an error if we received a totally empty set of artifacts, it's possible in the global build job under a very specific set of conditions:
In this case we need to make sure we still provide an upload_files array in the manifest so that we can always index into it.
Fixes #1387.