Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify path to Cargo.toml when generating wix for package #1454

Merged

Conversation

pnehrer
Copy link
Contributor

@pnehrer pnehrer commented Oct 15, 2024

To avoid an error when generating a wix file for a package whose Cargo.toml is in a sub-folder, specify the full path to the package's Cargo.toml.

Fixes Issue #1453.

@mistydemeo
Copy link
Contributor

Good catch, thank you! We're prepping a release right now, but I'll review and test this afterwards.

Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test to confirm this doesn't negatively effect wix projects in the standard root path. Looking good - thanks for this!

@mistydemeo mistydemeo merged commit 370c9d3 into axodotdev:main Oct 15, 2024
15 checks passed
@pnehrer
Copy link
Contributor Author

pnehrer commented Oct 16, 2024

Outstanding, thank you! 🙂

@ashleygwilliams ashleygwilliams added this to the 0.24.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants