-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce unified manifest file #1465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I popped this into BSD sha256sum, and confirmed it was happy using this as a check file.
I wonder if we might want to consider adding the hash file to the snapshots, so we can confirm the format stays stable? Not that I expect us to change code that modifies it often, but it feels roughly as snapshottable as the shell installers.
Just did that, which taught me about the snapshotting system for tests. |
ecb54bb
to
56d49c0
Compare
Hm, I guess the NPM package hash isn't actually stable, is it? If you're interested in learning about snapshot filtering, we could use that here to remove the unstable hash from the snapshots. Or we could punt on snapshotting the file contents at this point. |
Just noting here that @ashleygwilliams asked me to document why the npm packages aren't stable — which I will do ~around merging this PR, because I'll probably just end up skipping/censoring the checksums from the snapshots for the time being. |
56d49c0
to
8119650
Compare
8119650
to
04ae395
Compare
Right, I forget it doesn't hash the text installers, which are the things that would be stable. Yes, fine to drop it at this point. |
Closes #1321
This writes out unified checksum files like
sha256.sum
orsha512.sum
(which are compatible with GNU-stylesha256sum -c sha256.sum
invocations) depending on which checksum style is chosen from the dist config.It's a new global artifact which is built after all the local artifacts, re-using the checksums computed earlier. The plan is to eventually stop publishing individual checksum files like
some-binary.sha256
and only publish the unified checksum file, which will reduce noise / make publishing faster, etc.