Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish "cargo metadata failed" from "cargo is not installed" #1501

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Distinguish "cargo metadata failed" from "cargo is not installed" #1501

merged 1 commit into from
Oct 29, 2024

Conversation

fasterthanlime
Copy link
Contributor

Closes #1500

@fasterthanlime
Copy link
Contributor Author

in action:

CleanShot 2024-10-29 at 16 31 45@2x

@fasterthanlime
Copy link
Contributor Author

(note: this was a regression introduced recently, which was trying (and succeeding, tbh!) in improving this error message:

CleanShot 2024-10-29 at 16 32 52@2x

)

duckinator
duckinator approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@duckinator duckinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally and the implementation is about as simple as it gets. Looks good to me. 👍

mistydemeo
mistydemeo approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like a good heuristic!

@fasterthanlime fasterthanlime merged commit d58ba62 into main Oct 29, 2024
18 checks passed
@fasterthanlime fasterthanlime deleted the cargo-metadata-failures branch October 29, 2024 16:16
@mistydemeo mistydemeo mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckinator duckinator duckinator approved these changes

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"cargo metadata" returned non-zero exit code != "cargo" is not installed
3 participants
@fasterthanlime @duckinator @mistydemeo