Fiterx json array fix - unwanted NULL results in get_subscript #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed multiple issues in the original solution. 1. The conditional check for the index argument being in range was incorrect. The correct condition should have been `json_object_array_length(self->jso) < index + 1` to function as intended. 2. The range check was redundant. Since `object-json-array` inherits from `filterx-list-interface`, the range check is already properly implemented there. Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
MrAnno
approved these changes
Sep 4, 2024
alltilla
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FilterXJsonArray, which inherits fromFilterXList, performed a redundant range check in theget_subscriptmethod, leading to incorrectNULLresults in certain cases due to a bug. Since this range check is already handled in theFilterXListabstraction, the unnecessary and faulty code block has been removed.Additionally, some end-to-end tests for range checks have been added.