filterx: rework of unset_empties #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
reviewed
Sep 9, 2024
lib/filterx/func-unset-empties.c
Outdated
Comment on lines
60
to
67
| gsize str_len; | ||
| const gchar *str; | ||
| if (filterx_object_extract_string(obj, &str, &str_len) && str_len == 0) | ||
| return TRUE; | ||
|
|
There was a problem hiding this comment.
Why is this above the dict and list handling part, but the processing of it is below that?
lib/filterx/func-unset-empties.c
Outdated
| const gchar *str; | ||
| if (filterx_object_extract_string(obj, &str, &str_len) && str_len == 0) | ||
| return TRUE; | ||
|
|
||
| if (filterx_object_is_type(obj, &FILTERX_TYPE_NAME(dict)) || |
There was a problem hiding this comment.
It's a bit strange for me that the user cannot change the behavior of handling lists, dicts and nulls.
I don't know if they want to do it, but this seems asymmetric. If as a user I were to set the target strings, and nulls and empty dicts were getting removed, I would be surprised.
There was a problem hiding this comment.
what would be the proper way to handle that case?
bshifter
force-pushed
the
unset-empties-rework
branch
3 times, most recently
from
8b47daa to
ece5629
Compare
bshifter
changed the title
alltilla
reviewed
Sep 17, 2024
bshifter
force-pushed
the
unset-empties-rework
branch
7 times, most recently
from
9d7ebfa to
6942182
Compare
MrAnno
reviewed
Sep 23, 2024
bshifter
force-pushed
the
unset-empties-rework
branch
from
6942182 to
a5683a9
Compare
…ardize function flag handling Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
- filterx_expr_is_literal_generator function added - proper inner_dict_generator handling in filterx_expr_is_literal_dict_generator - proper inner_list_generator handling in filterx_expr_is_literal_list_generator Signed-off-by: shifter <shifter@axoflow.com>
- Default empty set: "", null, [], {}.
- Optional named arguments:
- recursive: Enables recursive processing of nested dictionaries.
- ignorecase: Enables case-insensitive matching.
- replacement: Specifies a filterxobject to replace target elements instead of removing them.
- targets: A list of elements to identify for removal or replacement, clearing the default empty set.
- UTF-8 support.
- ignorecase and recursive args are defaults to TRUE
This change removes elements from the given dictionary or list that match
the empty set. If the recursive argument is provided, the function will
process nested dictionaries as well. The replacement argument allows
replacing target elements with a specified object, and the targets
argument customizes which elements are removed or replaced, overriding
the default empty set.
Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
bshifter
force-pushed
the
unset-empties-rework
branch
from
a5683a9 to
2f53c8a
Compare
MrAnno
approved these changes
Sep 24, 2024
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Optional named arguments:
- UTF-8 support.
- ignorecase and recursive args are defaults to TRUE
example: