Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog-ng/webhook: add SOURCEIP and URL path+query param enrichment #89

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion syslog-ng/python-modules/webhook/scl/webhook.conf
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
block source webhook(
port("")
auth_token("")
paths([])
tls_key_file("")
tls_cert_file("")

Expand All @@ -39,6 +40,7 @@ block source webhook(
options(
"port" => "`port`"
"auth_token" => "`auth_token`"
"paths" => `paths`
"tls_key_file" => "`tls_key_file`"
"tls_cert_file" => "`tls_cert_file`"

Expand All @@ -55,6 +57,7 @@ block source webhook-json(
port("")
auth_token("")
prefix("")
paths([])
tls_key_file("")
tls_cert_file("")

Expand All @@ -69,7 +72,7 @@ block source webhook-json(
channel {
source {
webhook(
port("`port`") auth_token("`auth_token`")
port("`port`") auth_token("`auth_token`") paths(`paths`)
tls_key_file("`tls_key_file`") tls_cert_file("`tls_cert_file`")

tls_peer_verify(`tls_peer_verify`)
Expand Down
34 changes: 29 additions & 5 deletions syslog-ng/python-modules/webhook/source.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,39 @@

signal.signal(signal.SIGINT, signal.SIG_IGN)
signal.signal(signal.SIGTERM, signal.SIG_IGN)
WEBHOOK_QUERY_NV_PREFIX = "webhook.query."

class Handler(tornado.web.RequestHandler):
def initialize(self, source) -> None:
self.source = source

@tornado.web.authenticated
async def post(self) -> None:
async def post(self, **path_arguments) -> None:
# racy, but the client should retry
if self.source.suspended.is_set():
self.set_status(503)
await self.finish({"status": "flow-controlled"})
return

self.source.post_message(LogMessage(self.request.body))
msg = self._construct_msg(self.request, path_arguments)
self.source.post_message(msg)

await self.finish({"status": "received"})

def _construct_msg(self, request, path_arguments) -> LogMessage:
msg = LogMessage(self.request.body)

for key, value in request.query_arguments.items():
value = value[0] if len(value) == 1 else value
msg[WEBHOOK_QUERY_NV_PREFIX + key] = value

for key, value in path_arguments.items():
msg[key] = value

msg.set_source_ipaddress(self.request.remote_ip)

return msg

def set_default_headers(self) -> None:
self.set_header("Server", "syslog-ng");

Expand Down Expand Up @@ -84,10 +101,13 @@ def init(self, options: dict[str, Any]) -> bool:
self.suspended = threading.Event()
self.event_loop = asyncio.new_event_loop()
self.request_exit = asyncio.Event()

handlers = list(map(lambda p: (p, Handler, {"source": self}), self.paths))
if len(handlers) == 0:
handlers = [(r"/.*", Handler, {"source": self})]

self.app = tornado.web.Application(
[
(r"/.*", Handler, {"source": self}),
],
handlers,
log_function=self.log_access,
autoreload=False,
compress_response=False,
Expand Down Expand Up @@ -150,6 +170,10 @@ def init_options(self, options: dict[str, Any]) -> bool:
try:
self.port = options.get("port")
self.auth_token = options.get("auth_token")
self.paths = options.get("paths", [])
if isinstance(self.paths, str):
self.paths = [self.paths]

self.tls_key_file = options.get("tls_key_file")
self.tls_cert_file = options.get("tls_cert_file")

Expand Down