filterx: various small fixes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
force-pushed
the
filterx-small-fixes
branch
2 times, most recently
from
edf846c
to
3fe6048
Compare
MrAnno
reviewed
May 17, 2024
MrAnno
reviewed
May 17, 2024
| _assert_comparison(filterx_string_new("a443", 4), filterx_integer_new(443), FCMPX_NE | FCMPX_TYPE_AWARE, TRUE); | ||
|
|
||
| // bytes - boolean | ||
| _assert_comparison(filterx_bytes_new("true", 4), filterx_boolean_new(true), FCMPX_EQ | FCMPX_TYPE_AWARE, TRUE); | ||
| _assert_comparison(filterx_bytes_new("true", 4), filterx_boolean_new(true), FCMPX_EQ | FCMPX_TYPE_AWARE, FALSE); |
There was a problem hiding this comment.
This would have been great, but I guess it's not a big deal as it works with strings.
There was a problem hiding this comment.
We can write custom parsing logic for these, and convert them to 0 or 1 numbers then follow through with the number comparison. It might make sense.
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
json-c/json-c#539 Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
This saves a copy. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
format_hex_string_with_delimiter() needs enough space for the closing NUL. Fortunately it is allocated by g_string_set_size(), but we need to let format_hex_string_with_delimiter() know. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
They are expected to have NULs in them. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
filterx-small-fixes
branch
from
3fe6048
to
67696eb
Compare
MrAnno
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.