Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove need to add load_in* during merge #1017

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat: remove need to add load_in* during merge #1017

merged 1 commit into from
Dec 29, 2023

Conversation

NanoCode012
Copy link
Collaborator

Removes need to set these option to False via cli.

  • load_in_8bit
  • load_in_4bit
  • flash_attention due to loading without GPU

@hamelsmu
Copy link
Collaborator

This PR closes #1002 , I believe

@hamelsmu hamelsmu linked an issue Dec 29, 2023 that may be closed by this pull request
Can't merge in system RAM #1002
Closed
8 tasks
@NanoCode012
Copy link
Collaborator Author

This PR closes #1002 , I believe

I think that person's issue was related to max_memory(?) The corresponding fix should be in PR #918

@hamelsmu
Copy link
Collaborator

I think that person's issue was related to max_memory(?) The corresponding fix should be in PR #918

Oh I see sorry about that, I'll unlink

@hamelsmu hamelsmu removed a link to an issue Dec 29, 2023
Can't merge in system RAM #1002
Closed
8 tasks
@NanoCode012 NanoCode012 merged commit f6ecf14 into axolotl-ai-cloud:main Dec 29, 2023
4 checks passed
@NanoCode012 NanoCode012 deleted the feat/apply-flags-default-lora branch December 29, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamelsmu hamelsmu hamelsmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NanoCode012 @hamelsmu