Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more robust about checking embedding modules for lora finetunes #1074

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Jan 9, 2024

@mtenenholtz brought up in the discord that phi has a more nuanced embedding module name. this PR attempts to handle other architectures a little more gracefully

@winglian winglian merged commit 0f10080 into main Jan 10, 2024
6 checks passed
@winglian winglian deleted the lora-embeddings-checks branch January 10, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants