split up llama model loading so config can be loaded from base config and models can be loaded from a path #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and models can be loaded from a path
|
I'm not sure about others, but sometimes I use this base_model_config to point for tokenizer in a separate repo (maybe I'm using the bug as a feature). Should we have a |
NanoCode012
reviewed
May 31, 2023
|
There is a redundant import nearby as well. if TYPE_CHECKING:
from peft import PeftConfig # noqa: F401
from transformers import PreTrainedTokenizer # noqa: F401to if TYPE_CHECKING:
from peft import PeftConfig # noqa: F401The PreTrainedTokenizer is never used. And if it does not inconvenience you, could you also please add the cfg to readme? |
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
…/model-from-path split up llama model loading so config can be loaded from base config and models can be loaded from a path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just ran into this issue, this worked for me to get it working