Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker-compose file #146

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

FarisHijazi
Copy link
Contributor

simple docker file for development. It has a volume to use the code and also a volume for ~/.cache/huggingface so that it can use downloaded models

Copy link
Collaborator

@ehartford ehartford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the purpose of a docker-compose when we only have/need a single container

Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- driver: nvidia
# count: 1
capabilities: [gpu]
command: tail -f /dev/null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct command for local dev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command: tail -f /dev/null keeps the container running otherwise it will shutdown immediately

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sgtm, I may change it to use sleep infinity down the line, https://stackoverflow.com/a/35770783

@FarisHijazi
Copy link
Contributor Author

I don't see the purpose of a docker-compose when we only have/need a single container

if you have a way to just use a docker build/run command I'm more than happy to use that

@FarisHijazi FarisHijazi closed this Jun 2, 2023
@FarisHijazi FarisHijazi reopened this Jun 2, 2023
@winglian winglian merged commit 91992cb into axolotl-ai-cloud:main Jun 2, 2023
@winglian
Copy link
Collaborator

winglian commented Jun 2, 2023

Thanks @FarisHijazi !!!

mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants