remove the bos token from dpo outputs #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
force-pushed
the
dpo-outouts-no-bos
branch
from
08d0ce3
to
72d7c83
Compare
winglian
force-pushed
the
dpo-outouts-no-bos
branch
from
72d7c83
to
e07676d
Compare
NanoCode012
reviewed
Aug 30, 2024
| if res["prompt_input_ids"][0] == self.tokenizer.bos_token_id: | ||
| res["prompt_input_ids"] = res["prompt_input_ids"][1:] | ||
| res["prompt_attention_mask"] = res["prompt_attention_mask"][1:] | ||
|
|
There was a problem hiding this comment.
From the linked Issue, we should only remove the BOS from the chosen/rejected, right? The prompt should not require it?
If it does require removing bos, does res["prompt_labels"] exist & do we need to remove it also?
winglian
force-pushed
the
dpo-outouts-no-bos
branch
from
ea4d7a7
to
fc76ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1616