Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare plugins needs to happen so registration can occur to build the plugin args #2119

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Dec 3, 2024

bug introduced in #2091 from a refactor of the plugins causes the plugins to not actually load now

…e plugin args

use yaml.dump

include dataset and more assertions
@winglian winglian force-pushed the fix-prepare-plugin-order branch from d9737a7 to 2554359 Compare December 3, 2024 17:46
@winglian winglian merged commit d87df2c into main Dec 3, 2024
11 of 13 checks passed
@winglian winglian deleted the fix-prepare-plugin-order branch December 3, 2024 20:06
djsaunde pushed a commit that referenced this pull request Dec 16, 2024
…e plugin args (#2119)

* prepare plugins needs to happen so registration can occur to build the plugin args

use yaml.dump

include dataset and more assertions

* attempt to manually register plugins rather than use fn

* fix fixture

* remove fixture

* move cli test to patched dir

* fix cce validation
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
…e plugin args (#2119)

* prepare plugins needs to happen so registration can occur to build the plugin args

use yaml.dump

include dataset and more assertions

* attempt to manually register plugins rather than use fn

* fix fixture

* remove fixture

* move cli test to patched dir

* fix cce validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant